🧪 Volume size step1 #141
Merged
🧪 Volume size step1 #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanshan
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Issue SaaShup/netbox-docker-plugin#164 we can introduce volume size.
In Docker this is considered as a quota. As such this feature will only work with zfs or brtfs.
A new docker info is then created to check the Storage device. If it is overlay2 then the size is not applied.
No regression expected.
[X] docker info and storage driver check
[X] docker UI to show Storage Driver
[X] add size in volume creation.
in UI is the size is not yet reflected. Can be done when test envirronement has supported FS.